wForget commented on code in PR #9968:
URL: https://github.com/apache/incubator-gluten/pull/9968#discussion_r2149108718
##########
cpp/velox/memory/VeloxMemoryManager.cc:
##########
@@ -171,6 +172,8 @@ class ListenableArbitrator : public
velox::memory::MemoryArbitrator {
try {
listener_->allocationChanged(neededBytes);
} catch (const std::exception&) {
+ VLOG(2) << "ListenableArbitrator growCapacityInternal failed,
stacktrace: "
Review Comment:
> it could be `LOG(WARNING)`
This is not always an error, and in some scenarios where maybeReserve is
called to trigger a spill, this log info does not need to be displayed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
