zhztheplayer commented on code in PR #9984:
URL: https://github.com/apache/incubator-gluten/pull/9984#discussion_r2150406876
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxBackend.scala:
##########
@@ -468,10 +468,8 @@ object VeloxBackendSettings extends BackendSettingsApi {
override def supportColumnarShuffleExec(): Boolean = {
val conf = GlutenConfig.get
- conf.enableColumnarShuffle && (conf.isUseGlutenShuffleManager
- || conf.isUseColumnarShuffleManager
- || conf.isUseCelebornShuffleManager
- || conf.isUseUniffleShuffleManager)
Review Comment:
If these methods remain unused, may we move them to CHConfig?
Indeed it feels helpful too if we can finally remove the usages from CH
backend as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
