KevinyhZou commented on code in PR #9978:
URL: https://github.com/apache/incubator-gluten/pull/9978#discussion_r2151744067
##########
gluten-flink/runtime/src/main/java/org/apache/flink/streaming/runtime/translators/SourceTransformationTranslator.java:
##########
@@ -81,12 +82,29 @@ private Collection<Integer> translateInternal(
final ExecutionConfig executionConfig = streamGraph.getExecutionConfig();
// --- Begin Gluten-specific code changes ---
- if
(transformation.getSource().getClass().getSimpleName().equals("NexmarkSource"))
{
+ Class<?> sourceClazz = transformation.getSource().getClass();
+ if (sourceClazz.getSimpleName().equals("NexmarkSource")) {
Review Comment:
The source jars is not introduced as dependencies by maven, because
`nexmark-connector` source jar can notbe found at maven central repo; so here
we use java reflection. And the `runtime` module of gluten-flink is not good to
introduce some `connector` jars, I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
