zhztheplayer commented on code in PR #9999: URL: https://github.com/apache/incubator-gluten/pull/9999#discussion_r2153714262
########## gluten-substrait/src/main/scala/org/apache/gluten/extension/columnar/CommonSubexpressionEliminateRule.scala: ########## @@ -14,7 +14,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package org.apache.gluten.extension +package org.apache.gluten.extension.columnar Review Comment: (minor) This is an optimizer rule rather than a columnar rule so ideally we can keep it in package `org.apache.gluten.extension` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
