wForget commented on code in PR #10000:
URL:
https://github.com/apache/incubator-gluten/pull/10000#discussion_r2156590910
##########
cpp/velox/memory/VeloxMemoryManager.cc:
##########
@@ -294,12 +294,27 @@ MemoryUsageStats collectGlutenAllocatorMemoryUsageStats(
return stats;
}
+void logMemoryUsageStats(MemoryUsageStats stats, const std::string& name,
const std::string& logPrefix) {
+ VLOG(2) << logPrefix << "+- " << name
Review Comment:
> I just found every loop will print a log, could we pass a `stringstream`
ref to collect all usage stats and call `.str()` outside the loop?
Thanks, I will make a follow-up PR to improve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
