zhztheplayer commented on code in PR #10005:
URL:
https://github.com/apache/incubator-gluten/pull/10005#discussion_r2156562910
##########
gluten-substrait/src/main/scala/org/apache/gluten/extension/columnar/enumerated/RasOffload.scala:
##########
@@ -131,6 +134,9 @@ object RasOffload {
// TODO: Tag the original plan with fallback reason. This is
a non-trivial work
// in RAS as the query plan we got here may be a copy so
may not propagate tags
// to original plan.
+ if (FallbackTags.maybeOffloadable(from)) {
+ outComes.foreach(FallbackTags.add(from, _))
Review Comment:
Ahh, I see. the test has covered RAS. Would you add a comment here:
```
// FIXME: This is a solution that is not completely verified for all cases,
however it's no harm anyway so we
// temporarily apply this practice.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
