taiyang-li commented on code in PR #10026: URL: https://github.com/apache/incubator-gluten/pull/10026#discussion_r2160616635
########## cpp-ch/local-engine/Functions/SparkFunctionDateFromUnixDate.h: ########## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#pragma once +#include <Columns/ColumnVector.h> +#include <DataTypes/DataTypeDate32.h> +#include <DataTypes/DataTypesNumber.h> +#include <DataTypes/IDataType.h> +#include <Functions/FunctionFactory.h> +#include <Common/DateLUT.h> +#include <Common/DateLUTImpl.h> + +namespace DB +{ +namespace ErrorCodes +{ + extern const int NUMBER_OF_ARGUMENTS_DOESNT_MATCH; + extern const int ILLEGAL_TYPE_OF_ARGUMENT; +} +} + +namespace local_engine +{ +class SparkFunctionDateFromUnixDate : public DB::IFunction +{ +public: + static constexpr auto name = "sparkDateFromUnixDate"; + static DB::FunctionPtr create(DB::ContextPtr) { return std::make_shared<SparkFunctionDateFromUnixDate>(); } + SparkFunctionDateFromUnixDate() {} + ~SparkFunctionDateFromUnixDate() override = default; + String getName() const override { return name; } + bool isSuitableForShortCircuitArgumentsExecution(const DB::DataTypesWithConstInfo &) const override { return true; } + size_t getNumberOfArguments() const override { return 1; } + bool isVariadic() const override { return false; } + bool useDefaultImplementationForConstants() const override { return true; } + DB::DataTypePtr getReturnTypeImpl(const DB::ColumnsWithTypeAndName &) const override { return std::make_shared<DB::DataTypeDate32>(); } + + DB::ColumnPtr executeImpl(const DB::ColumnsWithTypeAndName & arguments, const DB::DataTypePtr & result_type, size_t input_rows) const override + { + if (arguments.size() != 1) + throw DB::Exception(DB::ErrorCodes::NUMBER_OF_ARGUMENTS_DOESNT_MATCH, "Function {} requires exactly 1 argument", name); + + DB::ColumnWithTypeAndName first_arg = arguments[0]; + auto arg_type = DB::removeNullable(first_arg.type); + + if (DB::isInteger(arg_type)) + return executeInternal<Int32>(first_arg.column, input_rows); + else + throw DB::Exception(DB::ErrorCodes::ILLEGAL_TYPE_OF_ARGUMENT, "Function {} requires integer argument", name); + } + + template<typename T> + DB::ColumnPtr executeInternal(const DB::ColumnPtr & col, size_t input_rows) const + { + const DB::ColumnVector<T> * col_src = checkAndGetColumn<DB::ColumnVector<T>>(col.get()); + DB::MutableColumnPtr res = DB::ColumnVector<Int32>::create(col->size()); + DB::PaddedPODArray<Int32> & data = assert_cast<DB::ColumnVector<Int32> *>(res.get())->getData(); + if (col->size() == 0) Review Comment: redundant codes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For additional commands, e-mail: commits-h...@gluten.apache.org
