zml1206 commented on code in PR #10036:
URL:
https://github.com/apache/incubator-gluten/pull/10036#discussion_r2162911556
##########
backends-velox/src/main/scala/org/apache/gluten/extension/PullOutDuplicateProject.scala:
##########
@@ -32,37 +32,47 @@ import scala.collection.mutable.ArrayBuffer
object PullOutDuplicateProject extends Rule[SparkPlan] with PredicateHelper {
override def apply(plan: SparkPlan): SparkPlan = plan.transformUp {
case l @ LimitExecTransformer(p: ProjectExecTransformer, _, _) =>
- val pullOutAliases = new ArrayBuffer[Alias]()
- val newChild = rewriteProject(p, AttributeSet.empty, pullOutAliases)
- if (pullOutAliases.isEmpty) {
+ val duplicates = calculateDuplicates(p, AttributeSet.empty)
+ if (duplicates.isEmpty) {
l
} else {
+ val pullOutAliases = new ArrayBuffer[Alias]()
+ val newChild = rewriteProject(p, AttributeSet.empty, pullOutAliases,
duplicates)
outerProject(l.copy(child = newChild), l.output, pullOutAliases)
}
case p @ ProjectExecTransformer(_, child: ProjectExecTransformer) =>
- val pullOutAliases = new ArrayBuffer[Alias]()
- val newChild = rewriteProject(child, AttributeSet.empty, pullOutAliases)
- val aliasMap = AttributeMap(pullOutAliases.map(a => a.toAttribute -> a))
- val newProjectList = p.projectList.map(replaceAliasButKeepName(_,
aliasMap))
- ProjectExecTransformer(newProjectList, newChild)
+ val duplicates = calculateDuplicates(child, AttributeSet.empty)
+ if (duplicates.isEmpty) {
+ p
+ } else {
+ val pullOutAliases = new ArrayBuffer[Alias]()
+ val newChild = rewriteProject(child, AttributeSet.empty,
pullOutAliases, duplicates)
+ val aliasMap = AttributeMap(pullOutAliases.map(a => a.toAttribute ->
a))
+ val newProjectList = p.projectList.map(replaceAliasButKeepName(_,
aliasMap))
+ ProjectExecTransformer(newProjectList, newChild)
+ }
case f @ FilterExecTransformer(_, child: ProjectExecTransformer) =>
- val pullOutAliases = new ArrayBuffer[Alias]()
- val newChild = rewriteProject(child, f.references, pullOutAliases)
- if (pullOutAliases.isEmpty) {
+ val duplicates = calculateDuplicates(child, f.references)
+ if (duplicates.isEmpty) {
f
} else {
+ val pullOutAliases = new ArrayBuffer[Alias]()
+ val newChild = rewriteProject(child, f.references, pullOutAliases,
duplicates)
outerProject(f.copy(child = newChild), f.output, pullOutAliases)
}
case bhj: BroadcastHashJoinExecTransformer
if bhj.streamedPlan.isInstanceOf[ProjectExecTransformer] =>
val pullOutAliases = new ArrayBuffer[Alias]()
Review Comment:
Please move pullOutAliases down.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
