Yohahaha commented on code in PR #10119:
URL:
https://github.com/apache/incubator-gluten/pull/10119#discussion_r2188876394
##########
backends-velox/src/main/scala/org/apache/gluten/config/VeloxConfig.scala:
##########
@@ -348,6 +348,14 @@ object VeloxConfig {
.booleanConf
.createWithDefault(false)
+ val COLUMNAR_VELOX_TASK_METRICS_TO_EVENT_LOG_THRESHOLD =
+
buildConf("spark.gluten.sql.columnar.backend.velox.taskMetricsToEventLog.threshold")
+ .internal()
+ .doc("Sets the threshold for writing task statistics to the event log if
the task runs " +
+ "longer than this value. Default is -1, meaning never write the stats
to the event log.")
+ .longConf
+ .createWithDefault(-1)
+
Review Comment:
I suggest declare the config with `.timeConf(TimeUnit.SECONDS)` or
MILLISECONDS, and modify comparison logic in cpp side.
for me, I prefer this config is seconds level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
