PHILO-HE commented on code in PR #10132:
URL:
https://github.com/apache/incubator-gluten/pull/10132#discussion_r2189037289
##########
gluten-flink/runtime/src/main/java/org/apache/gluten/table/runtime/operators/GlutenSingleInputOperator.java:
##########
@@ -121,21 +121,21 @@ public void processElement(StreamRecord<RowData> element)
{
if (state == UpIterator.State.AVAILABLE) {
final StatefulElement statefulElement = task.statefulGet();
outRv = statefulElement.asRecord().getRowVector();
- List<RowData> rows =
- FlinkRowToVLVectorConvertor.toRowData(
- outRv, allocator, outputTypes.values().iterator().next());
- for (RowData row : rows) {
- output.collect(outElement.replace(row));
+ try {
Review Comment:
One minor suggestion, can we just use try with resources?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
