zhztheplayer commented on code in PR #10138:
URL:
https://github.com/apache/incubator-gluten/pull/10138#discussion_r2193958230
##########
gluten-substrait/src/main/scala/org/apache/gluten/execution/ValidatablePlan.scala:
##########
@@ -43,7 +43,7 @@ trait ValidatablePlan extends GlutenPlan with LogLevelUtil {
try {
f
} catch {
- case e @ (_: GlutenNotSupportException | _:
UnsupportedOperationException) =>
+ case e @ (_: GlutenNotSupportException | _:
UnsupportedOperationException | _: Throwable) =>
Review Comment:
Would prefer catching `Exception` so we still allow fatal errors (e.g., a
heap OOM) to crash the application.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
