PHILO-HE commented on code in PR #10158:
URL:
https://github.com/apache/incubator-gluten/pull/10158#discussion_r2197067155
##########
dev/build_arrow.sh:
##########
@@ -35,9 +35,15 @@ function prepare_arrow_build() {
}
function build_arrow_cpp() {
- pushd $ARROW_PREFIX/cpp
-
- cmake_install \
+ pushd $ARROW_PREFIX/cpp
+ ARROW_WITH_ZLIB=ON
+ if [[ "$(uname)" == "Darwin" ]]; then
+ clang_major_version=$(echo | clang -dM -E - | grep __clang_major__ | awk
'{print $3}')
+ if [ "${clang_major_version}" -ge 17 ]; then
+ ARROW_WITH_ZLIB=OFF
Review Comment:
With ARROW_WITH_ZLIB=OFF, is there any impact on the functionalities?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org
