rui-mo commented on code in PR #10169:
URL:
https://github.com/apache/incubator-gluten/pull/10169#discussion_r2200048050
##########
backends-velox/src/main/scala/org/apache/gluten/metrics/MetricsUtil.scala:
##########
@@ -238,6 +238,16 @@ object MetricsUtil extends Logging {
operatorMetrics,
metrics.getSingleMetrics,
joinParamsMap.get(operatorIdx))
+ case nestedLoopJoinUpdater: NestedLoopJoinMetricsUpdater =>
+ // NestedLoopJoin outputs two suites of metrics respectively for
nested loop join build and
+ // nested loop join probe.
+ // Therefore, fetch one more suite of metrics here.
+ operatorMetrics.add(metrics.getOperatorMetrics(curMetricsIdx))
+ curMetricsIdx -= 1
+ nestedLoopJoinUpdater.updateJoinMetrics(
+ operatorMetrics,
+ metrics.getSingleMetrics,
+ joinParamsMap.get(operatorIdx))
Review Comment:
Looks like this branch could be combined with `HashJoinMetricsUpdater`
branch by extending the cases to match.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
