JkSelf commented on code in PR #10138:
URL:
https://github.com/apache/incubator-gluten/pull/10138#discussion_r2206387246
##########
gluten-substrait/src/main/scala/org/apache/gluten/execution/ValidatablePlan.scala:
##########
@@ -63,13 +65,26 @@ trait ValidatablePlan extends GlutenPlan with LogLevelUtil {
* Validate whether this SparkPlan supports to be transformed into substrait
node in Native Code.
*/
final def doValidate(): ValidationResult = {
- val schemaValidationResult = BackendsApiManager.getValidatorApiInstance
- .doSchemaValidate(schema)
- .map {
- reason =>
- ValidationResult.failed(s"Found schema check failure for $schema,
due to: $reason")
+ val schemaValidationResult =
+ try {
+ BackendsApiManager.getValidatorApiInstance
+ .doSchemaValidate(schema)
+ .map {
+ reason =>
+ ValidationResult.failed(
+ s"Found schema check failure for $schema, due to: $reason")
+ }
+ .getOrElse(ValidationResult.succeeded)
+ } catch {
+ case e: AnalysisException =>
Review Comment:
@PHILO-HE Yes. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
