zml1206 commented on code in PR #10158:
URL:
https://github.com/apache/incubator-gluten/pull/10158#discussion_r2212021736
##########
dev/builddeps-veloxbe.sh:
##########
@@ -48,7 +48,11 @@ VELOX_HOME=""
VELOX_PARAMETER=""
BUILD_ARROW=ON
SPARK_VERSION=ALL
-INSTALL_PREFIX=${INSTALL_PREFIX:-"/usr/local"}
+if [[ "$(uname)" == "Darwin" ]]; then
+ INSTALL_PREFIX=${INSTALL_PREFIX:-}
+else
+ INSTALL_PREFIX=${INSTALL_PREFIX:-"/usr/local"}
Review Comment:
It seems more appropriate to keep the default value of INSTALL_PREFIX
consistent with velox's macOS.
##########
dev/build_arrow.sh:
##########
@@ -35,9 +35,15 @@ function prepare_arrow_build() {
}
function build_arrow_cpp() {
- pushd $ARROW_PREFIX/cpp
-
- cmake_install \
+ pushd $ARROW_PREFIX/cpp
+ ARROW_WITH_ZLIB=ON
+ if [[ "$(uname)" == "Darwin" ]]; then
+ clang_major_version=$(echo | clang -dM -E - | grep __clang_major__ | awk
'{print $3}')
+ if [ "${clang_major_version}" -ge 17 ]; then
+ ARROW_WITH_ZLIB=OFF
Review Comment:
This is risky. We just temporarily disable zlib and enable it after arrow is
upgraded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
