lgbo-ustc commented on code in PR #10218: URL: https://github.com/apache/incubator-gluten/pull/10218#discussion_r2221072511
########## gluten-flink/planner/src/main/java/org/apache/gluten/rexnode/functions/RexCallConverterFactory.java: ########## @@ -56,10 +56,22 @@ public class RexCallConverterFactory { () -> new BasicArithmeticOperatorRexCallConverter("equalto"), () -> new StringCompareRexCallConverter("equalto"), () -> new StringNumberCompareRexCallConverter("equalto"))), + Map.entry("/", Arrays.asList(() -> new DecimalRexCallConverters("divide"))), Review Comment: basic number support is in another PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For additional commands, e-mail: commits-h...@gluten.apache.org