jinchengchenghh commented on code in PR #10240:
URL:
https://github.com/apache/incubator-gluten/pull/10240#discussion_r2224352268
##########
backends-velox/src/main/scala/org/apache/gluten/expression/VeloxBloomFilterMightContain.scala:
##########
@@ -26,21 +25,23 @@ import
org.apache.spark.sql.catalyst.expressions.{BinaryExpression, Expression}
import org.apache.spark.sql.catalyst.expressions.codegen._
import org.apache.spark.sql.catalyst.expressions.codegen.Block.BlockHelper
import org.apache.spark.sql.types.DataType
-import org.apache.spark.task.TaskResources
+
+import io.netty.util.internal.PlatformDependent
+import sun.nio.ch.DirectBuffer
+
+import java.io.{IOException, ObjectInputStream, ObjectOutputStream}
+import java.nio.{Buffer, ByteBuffer}
/**
* Velox's bloom-filter implementation uses different algorithms internally
comparing to vanilla
* Spark so produces different intermediate aggregate data. Thus we use
different filter function /
* agg function types for Velox's version to distinguish from vanilla Spark's
implementation.
- *
- * FIXME: Remove GlutenTaskOnlyExpression after the VeloxBloomFilter expr is
made compatible with
- * spark. See:
https://github.com/apache/incubator-gluten/pull/9850#issuecomment-3007448538
*/
case class VeloxBloomFilterMightContain(
bloomFilterExpression: Expression,
valueExpression: Expression)
- extends BinaryExpression
- with GlutenTaskOnlyExpression {
+ extends BinaryExpression {
+ import VeloxBloomFilterMightContain._
Review Comment:
Do we import here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
