KevinyhZou commented on code in PR #10248:
URL:
https://github.com/apache/incubator-gluten/pull/10248#discussion_r2241964859
##########
gluten-flink/ut/src/test/java/org/apache/gluten/table/runtime/stream/custom/ScalarFunctionsTest.java:
##########
@@ -169,4 +172,28 @@ void testDecimal() {
query = "select b + e as x from tblDecimal where a > 0";
runAndCheck(query, Arrays.asList("+I[2.0]", "+I[5.0]", "+I[7.0]"));
}
+
+ @Test
+ void testDateFormat() {
+ List<Row> rows =
+ Arrays.asList(Row.of(1, "2024-12-31 12:12:12"), Row.of(2, "2025-02-28
12:12:12"));
+ createSimpleBoundedValuesTable("dateFormatTbl", "a int, b string", rows);
+ String query =
+ "select a, DATE_FORMAT(cast(b as Timestamp(3)), 'yyyy-MM-dd'),
DATE_FORMAT(cast(b as Timestamp(3)), 'yyyy-MM-dd HH:mm:ss') from dateFormatTbl";
+ runAndCheck(
+ query,
+ Arrays.asList(
+ "+I[1, 2024-12-31, 2024-12-31 12:12:12]", "+I[2, 2025-02-28,
2025-02-28 12:12:12]"));
+ Map<String, String> configs =
+ Map.of(
+ VeloxQueryConfig.ADJUST_TIMESTMP_TO_SESSION_TIMEZONE.key(),
+ "true",
+ TableConfigOptions.LOCAL_TIME_ZONE.key(),
+ "America/Los_Angeles");
Review Comment:
The flink `create view` is `logical view`, data is materialized， so you
described above it is the same as `select ... date_format(cast(xxx as
timestamp), 'yyyy-MM-dd HH:mm:ss')`, and this is different from spark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
