zhouyuan commented on code in PR #10160:
URL:
https://github.com/apache/incubator-gluten/pull/10160#discussion_r2242245058
##########
backends-velox/src/main/scala/org/apache/gluten/execution/GenerateExecTransformer.scala:
##########
@@ -238,19 +239,29 @@ object PullOutGenerateProjectHelper extends
PullOutProjectHelper {
)
case JsonTuple(Seq(jsonObj, jsonPaths @ _*)) =>
val getJsons: IndexedSeq[Expression] = {
+ def wrapPath(path: String): String =
+ s"""$$['$path']"""
jsonPaths.map {
case jsonPath if jsonPath.foldable =>
Option(jsonPath.eval()) match {
- case Some(path) =>
- GetJsonObject(jsonObj, Literal.create(JSON_PATH_PREFIX +
path))
+ case Some(path: UTF8String) =>
Review Comment:
it looks like you added `UTF8String` explicitly here, is this a requirement
from some production usage?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
