zhztheplayer commented on code in PR #10335:
URL:
https://github.com/apache/incubator-gluten/pull/10335#discussion_r2248080956
##########
gluten-core/src/main/scala/org/apache/spark/util/SparkVersionUtil.scala:
##########
@@ -17,8 +17,15 @@
package org.apache.spark.util
object SparkVersionUtil {
+ val lteSpark32: Boolean = compareMajorMinorVersion((3, 2)) <= 0
+ private val comparedWithSpark33 = compareMajorMinorVersion((3, 3))
+ val ltSpark33: Boolean = comparedWithSpark33 < 0
Review Comment:
I meant `ltSpark33` is functionally equal to `lteSpark32`, we can remove the
former and use the latter everywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
