This is an automated email from the ASF dual-hosted git repository.
felixybw pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push:
new a77a36e60f [GLUTEN-10332] Remove unnecessary constructor for PlanNode
(#10333)
a77a36e60f is described below
commit a77a36e60f49bbac6cc57a76533a2b1b2d874e65
Author: Jiaan Geng <[email protected]>
AuthorDate: Tue Aug 5 02:06:42 2025 +0800
[GLUTEN-10332] Remove unnecessary constructor for PlanNode (#10333)
Remove unnecessary constructor for PlanNode.
---
.../java/org/apache/gluten/substrait/plan/PlanBuilder.java | 10 +---------
.../main/java/org/apache/gluten/substrait/plan/PlanNode.java | 6 ------
2 files changed, 1 insertion(+), 15 deletions(-)
diff --git
a/gluten-substrait/src/main/java/org/apache/gluten/substrait/plan/PlanBuilder.java
b/gluten-substrait/src/main/java/org/apache/gluten/substrait/plan/PlanBuilder.java
index f55393de89..0853ee4719 100644
---
a/gluten-substrait/src/main/java/org/apache/gluten/substrait/plan/PlanBuilder.java
+++
b/gluten-substrait/src/main/java/org/apache/gluten/substrait/plan/PlanBuilder.java
@@ -33,11 +33,6 @@ public class PlanBuilder {
private PlanBuilder() {}
- public static PlanNode makePlan(
- List<FunctionMappingNode> mappingNodes, List<RelNode> relNodes,
List<String> outNames) {
- return new PlanNode(mappingNodes, relNodes, outNames);
- }
-
public static PlanNode makePlan(
List<FunctionMappingNode> mappingNodes,
List<RelNode> relNodes,
@@ -72,10 +67,7 @@ public class PlanBuilder {
ExtensionBuilder.makeFunctionMapping(entry.getKey(),
entry.getValue());
mappingNodes.add(mappingNode);
}
- if (extension != null || outputSchema != null) {
- return makePlan(mappingNodes, relNodes, outNames, outputSchema,
extension);
- }
- return makePlan(mappingNodes, relNodes, outNames);
+ return makePlan(mappingNodes, relNodes, outNames, outputSchema, extension);
}
public static PlanNode makePlan(SubstraitContext subCtx, ArrayList<RelNode>
relNodes) {
diff --git
a/gluten-substrait/src/main/java/org/apache/gluten/substrait/plan/PlanNode.java
b/gluten-substrait/src/main/java/org/apache/gluten/substrait/plan/PlanNode.java
index 8727372919..2f0715ac1b 100644
---
a/gluten-substrait/src/main/java/org/apache/gluten/substrait/plan/PlanNode.java
+++
b/gluten-substrait/src/main/java/org/apache/gluten/substrait/plan/PlanNode.java
@@ -37,12 +37,6 @@ public class PlanNode implements Serializable {
private TypeNode outputSchema = null;
private AdvancedExtensionNode extension = null;
- PlanNode(List<FunctionMappingNode> mappingNodes, List<RelNode> relNodes,
List<String> outNames) {
- this.mappingNodes.addAll(mappingNodes);
- this.relNodes.addAll(relNodes);
- this.outNames.addAll(outNames);
- }
-
PlanNode(
List<FunctionMappingNode> mappingNodes,
List<RelNode> relNodes,
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
