zhztheplayer commented on code in PR #10404:
URL:
https://github.com/apache/incubator-gluten/pull/10404#discussion_r2267106181
##########
cpp/core/utils/ObjectStore.h:
##########
@@ -85,6 +81,13 @@ class ObjectStore {
private:
static ResourceMap<ObjectStore*>& stores();
+ static std::pair<ObjectStore*, ResourceHandle> lookup(ObjectHandle handle) {
+ ResourceHandle storeId = safeCast<ResourceHandle>(handle >>
(sizeof(ResourceHandle) * 8));
+ ResourceHandle resourceId = safeCast<ResourceHandle>(handle &
std::numeric_limits<ResourceHandle>::max());
+ auto store = stores().lookup(storeId);
+ return {store, resourceId};
Review Comment:
nit: We may move definition to `.cc`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
