zml1206 commented on code in PR #10350:
URL:
https://github.com/apache/incubator-gluten/pull/10350#discussion_r2271879237
##########
backends-velox/src-uniffle/main/java/org/apache/spark/shuffle/writer/VeloxUniffleColumnarShuffleWriter.java:
##########
@@ -193,7 +192,7 @@ protected void writeImpl(Iterator<Product2<K, V>> records) {
new Spiller() {
@Override
public long spill(MemoryTarget self, Spiller.Phase phase,
long size) {
- if (!Spillers.PHASE_SET_SPILL_ONLY.contains(phase)) {
+ if (!Spiller.Phase.SPILL.equals(phase)) {
Review Comment:
Nit: Can you unify the code style? Same as above, using pattern matching,
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org
