PHILO-HE commented on PR #10479: URL: https://github.com/apache/incubator-gluten/pull/10479#issuecomment-3204875492
> No idea how you got rid of the shims but thanks for iterating :) I replaced `new SparkSession` with `SparkSession.builder()` to create the session instance. In Spark 4.0, the builder API is kept in `sql.SparkSession`, and the classic SparkSession can be created with it by default. In addition, I removed `SparkSession.cleanupAnyExistingSession` which requires using classic SparkSession companion object, then requires shim layer to differentiate the type if we call it. It's redundant to the existing code which already covers the cleanup. @zhztheplayer, @zhouyuan, thanks for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
