Copilot commented on code in PR #9107:
URL: https://github.com/apache/incubator-gluten/pull/9107#discussion_r2296717233
##########
backends-clickhouse/src/main/scala/org/apache/gluten/utils/CHExpressionUtil.scala:
##########
@@ -207,6 +207,9 @@ object CHExpressionUtil {
MAKE_DATE -> DefaultValidator(),
ARRAY_APPEND -> DefaultValidator(),
JSON_OBJECT_KEYS -> DefaultValidator(),
- LUHN_CHECK -> DefaultValidator()
+ LUHN_CHECK -> DefaultValidator(),
+ VARCHAR_TYPE_WRITE_SIDE_CHECK -> DefaultValidator(),
+ CHAR_TYPE_WRITE_SIDE_CHECK -> DefaultValidator(),
+ READ_SIDE_PADDING -> DefaultValidator()
Review Comment:
DefaultValidator always returns false in its doValidate method, which means
these CharVarcharCodegenUtils functions will never be validated as supported in
the ClickHouse backend. This will cause these functions to fall back instead of
being properly handled.
```suggestion
VARCHAR_TYPE_WRITE_SIDE_CHECK -> CharVarcharCodegenValidator(),
CHAR_TYPE_WRITE_SIDE_CHECK -> CharVarcharCodegenValidator(),
READ_SIDE_PADDING -> CharVarcharCodegenValidator()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
