zml1206 commented on code in PR #10543:
URL:
https://github.com/apache/incubator-gluten/pull/10543#discussion_r2302732178
##########
gluten-substrait/src/main/scala/org/apache/spark/sql/execution/ColumnarCollapseTransformStages.scala:
##########
@@ -82,12 +82,10 @@ case class InputIteratorTransformer(child: SparkPlan)
extends UnaryTransformSupp
copy(child = newChild)
}
- private def forBroadcast(): Boolean = {
- child match {
- case ColumnarInputAdapter(c) if c.isInstanceOf[BroadcastQueryStageExec]
=> true
- case ColumnarInputAdapter(c) if c.isInstanceOf[BroadcastExchangeLike] =>
true
- case _ => false
- }
+ private def forBroadcast(): Boolean = child match {
+ case ColumnarInputAdapter(c) =>
+ c.isInstanceOf[BroadcastQueryStageExec] ||
c.isInstanceOf[BroadcastExchangeLike]
Review Comment:
suggestion: `case ColumnarInputAdapter(_: BroadcastQueryStageExec | _:
BroadcastExchangeLike) => true`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
