This is an automated email from the ASF dual-hosted git repository.
philo pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push:
new af3082ddc6 [TEST][VL] Reinclude "cast string to timestamp" test
(#10532)
af3082ddc6 is described below
commit af3082ddc69e5d83dd6692fc64a97b2d50e8a530
Author: PHILO-HE <[email protected]>
AuthorDate: Wed Aug 27 17:06:28 2025 +0800
[TEST][VL] Reinclude "cast string to timestamp" test (#10532)
---
.../apache/spark/util/DebuggableThreadUtils.scala | 37 ++++++++++++++++++++++
.../gluten/utils/velox/VeloxTestSettings.scala | 1 -
.../catalyst/expressions/GlutenAnsiCastSuite.scala | 8 +++--
.../sql/catalyst/expressions/GlutenCastSuite.scala | 8 +++--
.../gluten/utils/velox/VeloxTestSettings.scala | 1 -
.../catalyst/expressions/GlutenAnsiCastSuite.scala | 8 +++--
.../sql/catalyst/expressions/GlutenCastSuite.scala | 8 +++--
.../gluten/utils/velox/VeloxTestSettings.scala | 2 --
.../sql/catalyst/expressions/GlutenCastSuite.scala | 8 +++--
.../catalyst/expressions/GlutenTryCastSuite.scala | 8 +++--
.../gluten/utils/velox/VeloxTestSettings.scala | 2 --
.../sql/catalyst/expressions/GlutenCastSuite.scala | 8 +++--
.../catalyst/expressions/GlutenTryCastSuite.scala | 8 +++--
13 files changed, 77 insertions(+), 30 deletions(-)
diff --git
a/gluten-ut/common/src/test/scala/org/apache/spark/util/DebuggableThreadUtils.scala
b/gluten-ut/common/src/test/scala/org/apache/spark/util/DebuggableThreadUtils.scala
new file mode 100644
index 0000000000..294c5df291
--- /dev/null
+++
b/gluten-ut/common/src/test/scala/org/apache/spark/util/DebuggableThreadUtils.scala
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.util
+
+import scala.util.{Failure, Success, Try}
+
+object DebuggableThreadUtils {
+
+ /** Logs message for failure occurring during the execution of
ThreadUtils.parmap. */
+ def parmap[I, O](in: Seq[I], prefix: String, maxThreads: Int)(f: I => O):
Seq[O] = {
+ ThreadUtils.parmap(in, prefix, maxThreads) {
+ i =>
+ Try(f(i)) match {
+ case Success(result) => result
+ case Failure(exception) =>
+ // scalastyle:off println
+ println(s"Test failed for case: ${i.toString}:
${exception.getMessage}")
+ // scalastyle:on println
+ throw exception
+ }
+ }
+ }
+}
diff --git
a/gluten-ut/spark32/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
b/gluten-ut/spark32/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
index d9e6a4c5f9..b08d6ed056 100644
---
a/gluten-ut/spark32/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
+++
b/gluten-ut/spark32/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
@@ -77,7 +77,6 @@ class VeloxTestSettings extends BackendTestSettings {
.exclude("data type casting")
// Revised by setting timezone through config and commented unsupported
cases.
.exclude("cast string to timestamp")
- .excludeGlutenTest("cast string to timestamp")
.exclude("SPARK-36286: invalid string cast to timestamp")
enableSuite[GlutenAnsiCastSuiteWithAnsiModeOff]
diff --git
a/gluten-ut/spark32/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenAnsiCastSuite.scala
b/gluten-ut/spark32/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenAnsiCastSuite.scala
index 08c0808e03..687ff84aea 100644
---
a/gluten-ut/spark32/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenAnsiCastSuite.scala
+++
b/gluten-ut/spark32/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenAnsiCastSuite.scala
@@ -20,7 +20,7 @@ import org.apache.spark.sql.GlutenTestsTrait
import org.apache.spark.sql.catalyst.util.DateTimeTestUtils.{ALL_TIMEZONES,
UTC}
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types.{DataType, StringType, TimestampType}
-import org.apache.spark.util.ThreadUtils
+import org.apache.spark.util.DebuggableThreadUtils
import java.sql.Timestamp
import java.time.LocalDateTime
@@ -113,13 +113,15 @@ class GlutenTryCastSuite extends TryCastSuite with
GlutenTestsTrait {
}
testGluten("cast string to timestamp") {
- ThreadUtils.parmap(
+ DebuggableThreadUtils.parmap(
ALL_TIMEZONES
.filterNot(_.getId.contains("SystemV"))
.filterNot(_.getId.contains("Europe/Kyiv"))
.filterNot(_.getId.contains("America/Ciudad_Juarez"))
.filterNot(_.getId.contains("Antarctica/Vostok"))
- .filterNot(_.getId.contains("Pacific/Kanton")),
+ .filterNot(_.getId.contains("Pacific/Kanton"))
+ .filterNot(_.getId.contains("Asia/Tehran"))
+ .filterNot(_.getId.contains("Iran")),
prefix = "CastSuiteBase-cast-string-to-timestamp",
maxThreads = 1
) {
diff --git
a/gluten-ut/spark32/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenCastSuite.scala
b/gluten-ut/spark32/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenCastSuite.scala
index cd4351e708..1751252cc7 100644
---
a/gluten-ut/spark32/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenCastSuite.scala
+++
b/gluten-ut/spark32/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenCastSuite.scala
@@ -21,7 +21,7 @@ import
org.apache.spark.sql.catalyst.util.DateTimeTestUtils.{withDefaultTimeZone
import org.apache.spark.sql.catalyst.util.DateTimeUtils.{fromJavaTimestamp,
millisToMicros, TimeZoneUTC}
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types._
-import org.apache.spark.util.ThreadUtils
+import org.apache.spark.util.DebuggableThreadUtils
import java.sql.{Date, Timestamp}
import java.util.{Calendar, TimeZone}
@@ -169,13 +169,15 @@ class GlutenCastSuite extends CastSuite with
GlutenTestsTrait {
}
testGluten("cast string to timestamp") {
- ThreadUtils.parmap(
+ DebuggableThreadUtils.parmap(
ALL_TIMEZONES
.filterNot(_.getId.contains("SystemV"))
.filterNot(_.getId.contains("Europe/Kyiv"))
.filterNot(_.getId.contains("America/Ciudad_Juarez"))
.filterNot(_.getId.contains("Antarctica/Vostok"))
- .filterNot(_.getId.contains("Pacific/Kanton")),
+ .filterNot(_.getId.contains("Pacific/Kanton"))
+ .filterNot(_.getId.contains("Asia/Tehran"))
+ .filterNot(_.getId.contains("Iran")),
prefix = "CastSuiteBase-cast-string-to-timestamp",
maxThreads = 1
) {
diff --git
a/gluten-ut/spark33/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
b/gluten-ut/spark33/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
index 55909a2496..c8ab231273 100644
---
a/gluten-ut/spark33/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
+++
b/gluten-ut/spark33/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
@@ -118,7 +118,6 @@ class VeloxTestSettings extends BackendTestSettings {
.exclude("data type casting")
// Revised by setting timezone through config and commented unsupported
cases.
.exclude("cast string to timestamp")
- .excludeGlutenTest("cast string to timestamp")
.exclude("SPARK-36286: invalid string cast to timestamp")
enableSuite[GlutenCollectionExpressionsSuite]
// Rewrite in Gluten to replace Seq with Array
diff --git
a/gluten-ut/spark33/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenAnsiCastSuite.scala
b/gluten-ut/spark33/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenAnsiCastSuite.scala
index 08c0808e03..687ff84aea 100644
---
a/gluten-ut/spark33/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenAnsiCastSuite.scala
+++
b/gluten-ut/spark33/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenAnsiCastSuite.scala
@@ -20,7 +20,7 @@ import org.apache.spark.sql.GlutenTestsTrait
import org.apache.spark.sql.catalyst.util.DateTimeTestUtils.{ALL_TIMEZONES,
UTC}
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types.{DataType, StringType, TimestampType}
-import org.apache.spark.util.ThreadUtils
+import org.apache.spark.util.DebuggableThreadUtils
import java.sql.Timestamp
import java.time.LocalDateTime
@@ -113,13 +113,15 @@ class GlutenTryCastSuite extends TryCastSuite with
GlutenTestsTrait {
}
testGluten("cast string to timestamp") {
- ThreadUtils.parmap(
+ DebuggableThreadUtils.parmap(
ALL_TIMEZONES
.filterNot(_.getId.contains("SystemV"))
.filterNot(_.getId.contains("Europe/Kyiv"))
.filterNot(_.getId.contains("America/Ciudad_Juarez"))
.filterNot(_.getId.contains("Antarctica/Vostok"))
- .filterNot(_.getId.contains("Pacific/Kanton")),
+ .filterNot(_.getId.contains("Pacific/Kanton"))
+ .filterNot(_.getId.contains("Asia/Tehran"))
+ .filterNot(_.getId.contains("Iran")),
prefix = "CastSuiteBase-cast-string-to-timestamp",
maxThreads = 1
) {
diff --git
a/gluten-ut/spark33/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenCastSuite.scala
b/gluten-ut/spark33/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenCastSuite.scala
index 9be180930d..edfc182886 100644
---
a/gluten-ut/spark33/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenCastSuite.scala
+++
b/gluten-ut/spark33/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenCastSuite.scala
@@ -21,7 +21,7 @@ import
org.apache.spark.sql.catalyst.util.DateTimeTestUtils.{withDefaultTimeZone
import org.apache.spark.sql.catalyst.util.DateTimeUtils.{fromJavaTimestamp,
millisToMicros, TimeZoneUTC}
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types._
-import org.apache.spark.util.ThreadUtils
+import org.apache.spark.util.DebuggableThreadUtils
import java.sql.{Date, Timestamp}
import java.util.{Calendar, TimeZone}
@@ -194,13 +194,15 @@ class GlutenCastSuite extends CastSuite with
GlutenTestsTrait {
}
testGluten("cast string to timestamp") {
- ThreadUtils.parmap(
+ DebuggableThreadUtils.parmap(
ALL_TIMEZONES
.filterNot(_.getId.contains("SystemV"))
.filterNot(_.getId.contains("Europe/Kyiv"))
.filterNot(_.getId.contains("America/Ciudad_Juarez"))
.filterNot(_.getId.contains("Antarctica/Vostok"))
- .filterNot(_.getId.contains("Pacific/Kanton")),
+ .filterNot(_.getId.contains("Pacific/Kanton"))
+ .filterNot(_.getId.contains("Asia/Tehran"))
+ .filterNot(_.getId.contains("Iran")),
prefix = "CastSuiteBase-cast-string-to-timestamp",
maxThreads = 1
) {
diff --git
a/gluten-ut/spark34/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
b/gluten-ut/spark34/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
index c4b9bb3d18..d027e49f44 100644
---
a/gluten-ut/spark34/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
+++
b/gluten-ut/spark34/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
@@ -97,7 +97,6 @@ class VeloxTestSettings extends BackendTestSettings {
.exclude("data type casting")
// Revised by setting timezone through config and commented unsupported
cases.
.exclude("cast string to timestamp")
- .excludeGlutenTest("cast string to timestamp")
.exclude("cast from timestamp II")
.exclude("SPARK-36286: invalid string cast to timestamp")
.exclude("SPARK-39749: cast Decimal to string")
@@ -116,7 +115,6 @@ class VeloxTestSettings extends BackendTestSettings {
.exclude("data type casting")
// Revised by setting timezone through config and commented unsupported
cases.
.exclude("cast string to timestamp")
- .excludeGlutenTest("cast string to timestamp")
enableSuite[GlutenCollectionExpressionsSuite]
// Rewrite in Gluten to replace Seq with Array
.exclude("Shuffle")
diff --git
a/gluten-ut/spark34/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenCastSuite.scala
b/gluten-ut/spark34/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenCastSuite.scala
index 64fa85d37f..0e1af4a4e2 100644
---
a/gluten-ut/spark34/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenCastSuite.scala
+++
b/gluten-ut/spark34/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenCastSuite.scala
@@ -21,7 +21,7 @@ import
org.apache.spark.sql.catalyst.util.DateTimeTestUtils.{withDefaultTimeZone
import org.apache.spark.sql.catalyst.util.DateTimeUtils.{fromJavaTimestamp,
millisToMicros, TimeZoneUTC}
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types._
-import org.apache.spark.util.ThreadUtils
+import org.apache.spark.util.DebuggableThreadUtils
import java.sql.{Date, Timestamp}
import java.util.{Calendar, TimeZone}
@@ -166,13 +166,15 @@ class GlutenCastSuite extends CastWithAnsiOffSuite with
GlutenTestsTrait {
}
testGluten("cast string to timestamp") {
- ThreadUtils.parmap(
+ DebuggableThreadUtils.parmap(
ALL_TIMEZONES
.filterNot(_.getId.contains("SystemV"))
.filterNot(_.getId.contains("Europe/Kyiv"))
.filterNot(_.getId.contains("America/Ciudad_Juarez"))
.filterNot(_.getId.contains("Antarctica/Vostok"))
- .filterNot(_.getId.contains("Pacific/Kanton")),
+ .filterNot(_.getId.contains("Pacific/Kanton"))
+ .filterNot(_.getId.contains("Asia/Tehran"))
+ .filterNot(_.getId.contains("Iran")),
prefix = "CastSuiteBase-cast-string-to-timestamp",
maxThreads = 1
) {
diff --git
a/gluten-ut/spark34/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenTryCastSuite.scala
b/gluten-ut/spark34/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenTryCastSuite.scala
index 1e1da8b0f1..3b2dcae63b 100644
---
a/gluten-ut/spark34/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenTryCastSuite.scala
+++
b/gluten-ut/spark34/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenTryCastSuite.scala
@@ -21,7 +21,7 @@ import
org.apache.spark.sql.catalyst.util.DateTimeTestUtils.{withDefaultTimeZone
import org.apache.spark.sql.catalyst.util.DateTimeUtils.{fromJavaTimestamp,
millisToMicros, TimeZoneUTC}
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types.{BinaryType, ByteType, DateType, Decimal,
DecimalType, DoubleType, FloatType, IntegerType, LongType, ShortType,
StringType, TimestampType}
-import org.apache.spark.util.ThreadUtils
+import org.apache.spark.util.DebuggableThreadUtils
import java.sql.{Date, Timestamp}
import java.util.{Calendar, TimeZone}
@@ -104,13 +104,15 @@ class GlutenTryCastSuite extends TryCastSuite with
GlutenTestsTrait {
}
testGluten("cast string to timestamp") {
- ThreadUtils.parmap(
+ DebuggableThreadUtils.parmap(
ALL_TIMEZONES
.filterNot(_.getId.contains("SystemV"))
.filterNot(_.getId.contains("Europe/Kyiv"))
.filterNot(_.getId.contains("America/Ciudad_Juarez"))
.filterNot(_.getId.contains("Antarctica/Vostok"))
- .filterNot(_.getId.contains("Pacific/Kanton")),
+ .filterNot(_.getId.contains("Pacific/Kanton"))
+ .filterNot(_.getId.contains("Asia/Tehran"))
+ .filterNot(_.getId.contains("Iran")),
prefix = "CastSuiteBase-cast-string-to-timestamp",
maxThreads = 1
) {
diff --git
a/gluten-ut/spark35/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
b/gluten-ut/spark35/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
index cebb51ee69..111f3fc912 100644
---
a/gluten-ut/spark35/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
+++
b/gluten-ut/spark35/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala
@@ -97,7 +97,6 @@ class VeloxTestSettings extends BackendTestSettings {
.exclude("data type casting")
// Revised by setting timezone through config and commented unsupported
cases.
.exclude("cast string to timestamp")
- .excludeGlutenTest("cast string to timestamp")
.exclude("cast from timestamp II")
.exclude("SPARK-36286: invalid string cast to timestamp")
.exclude("SPARK-39749: cast Decimal to string")
@@ -116,7 +115,6 @@ class VeloxTestSettings extends BackendTestSettings {
.exclude("data type casting")
// Revised by setting timezone through config and commented unsupported
cases.
.exclude("cast string to timestamp")
- .excludeGlutenTest("cast string to timestamp")
enableSuite[GlutenCollectionExpressionsSuite]
// Rewrite in Gluten to replace Seq with Array
.exclude("Shuffle")
diff --git
a/gluten-ut/spark35/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenCastSuite.scala
b/gluten-ut/spark35/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenCastSuite.scala
index 7cf89937a6..ef06a98539 100644
---
a/gluten-ut/spark35/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenCastSuite.scala
+++
b/gluten-ut/spark35/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenCastSuite.scala
@@ -21,7 +21,7 @@ import
org.apache.spark.sql.catalyst.util.DateTimeTestUtils.{withDefaultTimeZone
import org.apache.spark.sql.catalyst.util.DateTimeUtils.{fromJavaTimestamp,
millisToMicros, TimeZoneUTC}
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types._
-import org.apache.spark.util.ThreadUtils
+import org.apache.spark.util.DebuggableThreadUtils
import java.sql.{Date, Timestamp}
import java.util.{Calendar, TimeZone}
@@ -169,13 +169,15 @@ class GlutenCastSuite extends CastWithAnsiOffSuite with
GlutenTestsTrait {
}
testGluten("cast string to timestamp") {
- ThreadUtils.parmap(
+ DebuggableThreadUtils.parmap(
ALL_TIMEZONES
.filterNot(_.getId.contains("SystemV"))
.filterNot(_.getId.contains("Europe/Kyiv"))
.filterNot(_.getId.contains("America/Ciudad_Juarez"))
.filterNot(_.getId.contains("Antarctica/Vostok"))
- .filterNot(_.getId.contains("Pacific/Kanton")),
+ .filterNot(_.getId.contains("Pacific/Kanton"))
+ .filterNot(_.getId.contains("Asia/Tehran"))
+ .filterNot(_.getId.contains("Iran")),
prefix = "CastSuiteBase-cast-string-to-timestamp",
maxThreads = 1
) {
diff --git
a/gluten-ut/spark35/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenTryCastSuite.scala
b/gluten-ut/spark35/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenTryCastSuite.scala
index 526624be56..063b646981 100644
---
a/gluten-ut/spark35/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenTryCastSuite.scala
+++
b/gluten-ut/spark35/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenTryCastSuite.scala
@@ -21,7 +21,7 @@ import
org.apache.spark.sql.catalyst.util.DateTimeTestUtils.{withDefaultTimeZone
import org.apache.spark.sql.catalyst.util.DateTimeUtils.{fromJavaTimestamp,
millisToMicros, TimeZoneUTC}
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types.{BinaryType, ByteType, DateType, Decimal,
DecimalType, DoubleType, FloatType, IntegerType, LongType, ShortType,
StringType, TimestampType}
-import org.apache.spark.util.ThreadUtils
+import org.apache.spark.util.DebuggableThreadUtils
import java.sql.{Date, Timestamp}
import java.util.{Calendar, TimeZone}
@@ -105,13 +105,15 @@ class GlutenTryCastSuite extends TryCastSuite with
GlutenTestsTrait {
}
testGluten("cast string to timestamp") {
- ThreadUtils.parmap(
+ DebuggableThreadUtils.parmap(
ALL_TIMEZONES
.filterNot(_.getId.contains("SystemV"))
.filterNot(_.getId.contains("Europe/Kyiv"))
.filterNot(_.getId.contains("America/Ciudad_Juarez"))
.filterNot(_.getId.contains("Antarctica/Vostok"))
- .filterNot(_.getId.contains("Pacific/Kanton")),
+ .filterNot(_.getId.contains("Pacific/Kanton"))
+ .filterNot(_.getId.contains("Asia/Tehran"))
+ .filterNot(_.getId.contains("Iran")),
prefix = "CastSuiteBase-cast-string-to-timestamp",
maxThreads = 1
) {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
