marin-ma commented on code in PR #10540:
URL:
https://github.com/apache/incubator-gluten/pull/10540#discussion_r2306725906
##########
cpp/velox/utils/ConfigExtractor.h:
##########
@@ -28,12 +28,21 @@
namespace gluten {
+enum class FileSystemType : uint8_t {
+ kHdfs = 1 << 0,
+ kS3 = 1 << 1,
+ kAbfs = 1 << 2,
+ kGcs = 1 << 3,
+ kAll = (1 << 4) - 1
Review Comment:
One bit is used for each fs type and we check if the corresponding bit is
set. Seems like 0, 1, 2, 3 can't do the job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
