marin-ma commented on code in PR #10499:
URL:
https://github.com/apache/incubator-gluten/pull/10499#discussion_r2310389593
##########
backends-velox/src/main/scala/org/apache/gluten/vectorized/ColumnarBatchSerializer.scala:
##########
@@ -68,16 +69,21 @@ class ColumnarBatchSerializer(
override def supportsRelocationOfSerializedObjects: Boolean = true
}
-private class ColumnarBatchSerializerInstance(
+private class ColumnarBatchSerializerInstanceImpl(
schema: StructType,
readBatchNumRows: SQLMetric,
numOutputRows: SQLMetric,
deserializeTime: SQLMetric,
decompressTime: SQLMetric,
shuffleWriterType: ShuffleWriterType)
- extends SerializerInstance
+ extends ColumnarBatchSerializerInstance
with Logging {
+ private val runtime =
Review Comment:
It's also used when creating the output `ColumnarBatchOutIterator`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
