beliefer commented on code in PR #10545:
URL:
https://github.com/apache/incubator-gluten/pull/10545#discussion_r2312242124
##########
gluten-substrait/src/main/scala/org/apache/gluten/execution/WholeStageTransformer.scala:
##########
@@ -446,10 +446,11 @@ case class WholeStageTransformer(child: SparkPlan,
materializeInput: Boolean = f
/**
* the whole stage contains NO [[LeafTransformSupport]]. this the
default case for:
- * 1. SCAN with clickhouse backend (check
ColumnarCollapseTransformStages#separateScanRDD())
- * 2. test case where query plan is constructed from simple
dataframes (e.g.
- * GlutenDataFrameAggregateSuite) in these cases, separate RDDs
takes care of SCAN as a
- * result, genFinalStageIterator rather than genFirstStageIterator
will be invoked
+ * 1. SCAN with clickhouse backend (check
Review Comment:
I just want replace `ColumnarCollapseTransformStages#separateScanRDD()` with
`BackendsApiManager.getSettings.excludeScanExecFromCollapsedStage()`, but the
spotless make this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
