Yifeng-Wang commented on code in PR #9107:
URL: https://github.com/apache/incubator-gluten/pull/9107#discussion_r2312848811
##########
backends-velox/src/test/scala/org/apache/gluten/functions/ScalarFunctionsValidateSuite.scala:
##########
@@ -622,6 +622,47 @@ abstract class ScalarFunctionsValidateSuite extends
FunctionsValidateSuite {
}
}
+ // Add test suite for CharVarcharCodegenUtils functions.
+ // A ProjectExecTransformer is expected to be constructed after expr support.
+ // We currently test below functions with Spark v3.4
+ testWithMinSparkVersion("Test charTypeWriteSideCheck function", "3.4") {
Review Comment:
Yes, all these functions should be tested with min Spark version 3.4,
1. readSidePadding
was introduced at `branch-3.4` in
`sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/util/CharVarcharCodegenUtils.java`.
2. charTypeWriteSideCheck & varcharTypeWriteSideCheck
prior to 3.4, Spark's analyzer introduces an extra redundant cast(... as
string) expression. The current transformer for StaticInvoke does not handle
this specific pattern with the extra cast, which causes a fallback to the
vanilla Spark ProjectExec.
<img width="1739" height="507" alt="image"
src="https://github.com/user-attachments/assets/9cc8defc-fff2-46ab-a19e-619a27ca535e";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
