zhouyuan commented on code in PR #10497: URL: https://github.com/apache/incubator-gluten/pull/10497#discussion_r2313642323
########## cpp/velox/utils/ConfigExtractor.cc: ########## @@ -281,7 +281,7 @@ std::shared_ptr<facebook::velox::config::ConfigBase> getHiveConfig( hiveConfMap[facebook::velox::connector::hive::HiveConfig::kParquetUseColumnNames] = "true"; hiveConfMap[facebook::velox::connector::hive::HiveConfig::kOrcUseColumnNames] = "true"; - return std::make_shared<facebook::velox::config::ConfigBase>(std::move(hiveConfMap)); + return std::make_shared<facebook::velox::config::ConfigBase>(std::move(hiveConfMap), true); Review Comment: This config may introduce issue on latest main, as the azure client is expects some readonly config -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
