KevinyhZou commented on PR #10572: URL: https://github.com/apache/incubator-gluten/pull/10572#issuecomment-3241986270
> @jinchengchenghh, I just became aware of this. The current Flink CI has already added some Maven arguments (including the proposed args of this PR) that ensure compilation and tests pass on JDK 17. See the link below. > > @KevinyhZou, could you help confirm whether these remaining arguments also need to be added? @jinchengchenghh has provided a more comprehensive list, some of which are not necessary now but may become necessary in the future. Perhaps we should also consider adding these. > > https://github.com/apache/incubator-gluten/blob/05c8703dd3473f4008bbc0196a7b083cc032ee17/.github/workflows/flink.yml#L25-L29 As jdk17 is still a experimental feature on flink-1.19: https://nightlies.apache.org/flink/flink-docs-release-1.19/docs/deployment/java_compatibility/#java-17, I think we'd better add these options to avoid the incompatibility on flinkļ¼or we should use jdk11 @PHILO-HE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
