zjuwangg commented on code in PR #10603:
URL: 
https://github.com/apache/incubator-gluten/pull/10603#discussion_r2315514258


##########
docs/velox-configuration.md:
##########
@@ -9,77 +9,9 @@ nav_order: 16
 
 ## Gluten Velox backend configurations
 
-|                                       Key                                    
    |      Default      |                                                       
                                                                                
                                                                               
Description                                                                     
                                                                                
                                                                 |
-|----------------------------------------------------------------------------------|-------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
-| spark.gluten.sql.columnar.backend.velox.IOThreads                            
    | <undefined> | The Size of the IO thread pool in the Connector. This 
thread pool is used for split preloading and DirectBufferedInput. By default, 
the value is the same as the maximum task slots per Spark executor.             
                                                                                
                                                                                
                                                                  |
-| spark.gluten.sql.columnar.backend.velox.SplitPreloadPerDriver                
    | 2                 | The split preload per task                            
                                                                                
                                                                                
                                                                                
                                                                                
                                                                |
-| spark.gluten.sql.columnar.backend.velox.abandonPartialAggregationMinPct      
    | 90                | If partial aggregation aggregationPct greater than 
this value, partial aggregation may be early abandoned. Note: this option only 
works when flushable partial aggregation is enabled. Ignored when 
spark.gluten.sql.columnar.backend.velox.flushablePartialAggregation=false.      
                                                                                
                                                                                
  |
-| spark.gluten.sql.columnar.backend.velox.abandonPartialAggregationMinRows     
    | 100000            | If partial aggregation input rows number greater than 
this value,  partial aggregation may be early abandoned. Note: this option only 
works when flushable partial aggregation is enabled. Ignored when 
spark.gluten.sql.columnar.backend.velox.flushablePartialAggregation=false.      
                                                                                
                                                                              |
-| spark.gluten.sql.columnar.backend.velox.asyncTimeoutOnTaskStopping           
    | 30000ms           | Timeout for asynchronous execution when task is being 
stopped in Velox backend. It's recommended to set to a number larger than 
network connection timeout that the possible aysnc tasks are relying on.        
                                                                                
                                                                                
                                                                      |
-| spark.gluten.sql.columnar.backend.velox.bloomFilter.expectedNumItems         
    | 1000000           | The default number of expected items for the velox 
bloomfilter: 'spark.bloom_filter.expected_num_items'                            
                                                                                
                                                                                
                                                                                
                                                                   |
-| spark.gluten.sql.columnar.backend.velox.bloomFilter.maxNumBits               
    | 4194304           | The max number of bits to use for the velox bloom 
filter: 'spark.bloom_filter.max_num_bits'                                       
                                                                                
                                                                                
                                                                                
                                                                    |
-| spark.gluten.sql.columnar.backend.velox.bloomFilter.numBits                  
    | 8388608           | The default number of bits to use for the velox bloom 
filter: 'spark.bloom_filter.num_bits'                                           
                                                                                
                                                                                
                                                                                
                                                                |
-| spark.gluten.sql.columnar.backend.velox.cacheEnabled                         
    | false             | Enable Velox cache, default off. It's recommended to 
enablesoft-affinity as well when enable velox cache.                            
                                                                                
                                                                                
                                                                                
                                                                 |

Review Comment:
   @zhouyuan I used the `dev/gen_all_config_docs.sh` to re-generate the 
`configuration.md`. I'will review this config and add back this config item if 
needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to