rui-mo commented on code in PR #10567:
URL:
https://github.com/apache/incubator-gluten/pull/10567#discussion_r2316099446
##########
gluten-substrait/src/main/scala/org/apache/gluten/backendsapi/SparkPlanExecApi.scala:
##########
@@ -470,6 +470,18 @@ trait SparkPlanExecApi {
TruncTimestampTransformer(substraitExprName, format, timestamp, original)
}
+ def genToUnixTimestampTransformer(
+ substraitExprName: String,
+ timeExp: ExpressionTransformer,
+ format: ExpressionTransformer,
+ original: Expression): ExpressionTransformer = {
Review Comment:
The implementation can be removed from this API, and allow backend to
provide specific implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
