zml1206 commented on code in PR #10587:
URL:
https://github.com/apache/incubator-gluten/pull/10587#discussion_r2312743991
##########
gluten-substrait/src/main/scala/org/apache/gluten/utils/SubstraitUtil.scala:
##########
@@ -107,4 +108,20 @@ object SubstraitUtil {
val nameList = ConverterUtils.collectAttributeNamesWithExprId(output)
createNameStructBuilder(typeList, nameList,
Collections.emptyList()).build()
}
+
+ def convertJavaObjectToAny(obj: AnyRef): Any = {
+ if (obj == null) return null
+ var msg: Message = null
+ obj match {
+ case Some(s: String) => msg = StringValue.newBuilder.setValue(s).build
Review Comment:
Why use `Some` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org
