beliefer commented on code in PR #10638:
URL:
https://github.com/apache/incubator-gluten/pull/10638#discussion_r2331829815
##########
dev/build_helper_functions.sh:
##########
@@ -137,6 +137,11 @@ function cmake_install {
"$@"
cmake --build "${BINARY_DIR}"
+ if [ -z "${SUDO}" ]; then
+ if command -v sudo >/dev/null 2>&1 && sudo -n true 2>/dev/null; then
+ SUDO="sudo"
Review Comment:
> It seems line 21 should be changed to `SUDO="${SUDO:-""}"`, where all
letters are capitalized. Then, I assume setting `SUDO=sudo` in the environment
should work.
I tried this way, it works well. But I don't know if it will affect other OS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
