zml1206 commented on code in PR #10573:
URL:
https://github.com/apache/incubator-gluten/pull/10573#discussion_r2332197995
##########
gluten-arrow/src/main/java/org/apache/gluten/columnarbatch/ColumnarBatches.java:
##########
@@ -381,29 +397,31 @@ public static void release(ColumnarBatch b) {
b.close();
}
- private static IndicatorVector getIndicatorVector(ColumnarBatch input) {
- if (!isLightBatch(input)) {
+ private static IndicatorVector getIndicatorVector(ColumnarBatch input,
BatchType batchType) {
+ if (!isLightBatch(batchType)) {
throw new UnsupportedOperationException("Input batch is not light
batch");
}
return (IndicatorVector) input.column(0);
}
- public static long getNativeHandle(String backendName, ColumnarBatch batch) {
- if (isZeroColumnBatch(batch)) {
+ public static long getNativeHandle(String backendName, ColumnarBatch batch,
BatchType batchType) {
Review Comment:
nit: There are multiple separate calls to getNativeHandle, we can overload
it to simplify the call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
