acvictor commented on code in PR #9473:
URL: https://github.com/apache/incubator-gluten/pull/9473#discussion_r2332460111
##########
backends-velox/src/main/scala/org/apache/gluten/execution/HashAggregateExecTransformer.scala:
##########
@@ -716,6 +716,46 @@ case class RegularHashAggregateExecTransformer(
ignoreNullKeys
) {
+ override def isOffloadedSortExec: Boolean = false
+
+ override protected def allowFlush: Boolean = false
+
+ override def simpleString(maxFields: Int): String =
+ s"${super.simpleString(maxFields)}"
+
+ override def verboseString(maxFields: Int): String =
+ s"${super.verboseString(maxFields)}"
+
+ override protected def withNewChildInternal(newChild: SparkPlan):
HashAggregateExecTransformer = {
+ copy(child = newChild)
+ }
+}
+
+// Hash aggregation that is offloaded from sort aggregation.
+// Is identical to RegularHashAggregateExecTransformer but with a
+// different value of isOffloadedSortExec.
+case class OffloadedSortHashAggregateExecTransformer(
+ requiredChildDistributionExpressions: Option[Seq[Expression]],
+ groupingExpressions: Seq[NamedExpression],
+ aggregateExpressions: Seq[AggregateExpression],
+ aggregateAttributes: Seq[Attribute],
+ override val initialInputBufferOffset: Int,
+ resultExpressions: Seq[NamedExpression],
+ child: SparkPlan,
+ ignoreNullKeys: Boolean = false)
+ extends HashAggregateExecTransformer(
+ requiredChildDistributionExpressions,
+ groupingExpressions,
+ aggregateExpressions,
+ aggregateAttributes,
+ initialInputBufferOffset,
+ resultExpressions,
+ child,
+ ignoreNullKeys
+ ) {
+
+ override def isOffloadedSortExec: Boolean = true
+
Review Comment:
> Let's override the `requiredChildOrdering` and `outputOrdering` so that
this API doesn't have to be added.
>
> The implementation may be the same with Spark's `SortAggrtegateExec`:
>
>
https://github.com/apache/spark/blob/abecd4affbd9102d73434caf1f1ca00bda9ef6fe/sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/SortAggregateExec.scala#L50-L56
@zhztheplayer I tried this approach but it does eliminate the sort in some
cases, for example `drop redundant partial sort which has pre-project when
offload sortAgg`. Do you think it is okay to retain the bool API?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
