beliefer commented on code in PR #10669:
URL:
https://github.com/apache/incubator-gluten/pull/10669#discussion_r2339802756
##########
shims/common/src/main/scala/org/apache/spark/sql/execution/window/WindowGroupLimitExecShim.scala:
##########
@@ -21,18 +21,18 @@ import org.apache.spark.sql.catalyst.InternalRow
import org.apache.spark.sql.catalyst.expressions.{Attribute, Expression,
SortOrder}
import org.apache.spark.sql.execution.{SparkPlan, UnaryExecNode}
-sealed trait WindowGroupLimitMode
+sealed trait GlutenWindowGroupLimitMode
-case object Partial extends WindowGroupLimitMode
+case object GlutenPartial extends GlutenWindowGroupLimitMode
-case object Final extends WindowGroupLimitMode
+case object GlutenFinal extends GlutenWindowGroupLimitMode
Review Comment:
Because Spark 3.2 and Spark 3.3 don't have `WindowGroupLimitMode`, Spark 3.4
and later versions added this trait. Gluten added the WindowGroupLimitMode with
the same name as Spark did. I think the author want to solve the compilation
issue that Spark 3.2 and 3.3 missing `WindowGroupLimitMode`.
For sharing `WindowGroupLimitExecShim`, rename them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
