KevinyhZou commented on code in PR #10057:
URL:
https://github.com/apache/incubator-gluten/pull/10057#discussion_r2333382405
##########
gluten-flink/ut/src/test/java/org/apache/gluten/table/runtime/stream/custom/ScalarFunctionsTest.java:
##########
@@ -126,4 +126,20 @@ void testEqual() {
String query4 = "select c = d as x from tblEqual where a > 0";
runAndCheck(query4, Arrays.asList("+I[false]", "+I[true]", "+I[false]"));
}
+
+ @Test
+ void testSplitIndex() {
+ List<Row> rows =
+ Arrays.asList(
Review Comment:
I have copyed some related flink tests here, but others tests e.g. `index`
parameter is null or `delimiter` parameter is null, can not run here. as we can
not pass the the null constant parameter value to velox. Or we should
introduced a Variant to pass `null` constant.
##########
gluten-flink/ut/src/test/java/org/apache/gluten/table/runtime/stream/custom/ScalarFunctionsTest.java:
##########
@@ -126,4 +126,20 @@ void testEqual() {
String query4 = "select c = d as x from tblEqual where a > 0";
runAndCheck(query4, Arrays.asList("+I[false]", "+I[true]", "+I[false]"));
}
+
+ @Test
+ void testSplitIndex() {
+ List<Row> rows =
+ Arrays.asList(
Review Comment:
I have copyed some related flink tests here, but others tests e.g. `index`
parameter is null or `delimiter` parameter is null, can not run here. as we can
not pass the the null constant parameter value to velox. Or we should introduce
a Variant to pass `null` constant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
