This is an automated email from the ASF dual-hosted git repository.
philo pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push:
new 0cd8b7781e [GLUTEN-10703] Refactor `PlanNode` to avoid `addAll` call
(#10704)
0cd8b7781e is described below
commit 0cd8b7781efc0fc73e7b76660d4c5c813be6b2db
Author: Jiaan Geng <[email protected]>
AuthorDate: Wed Sep 17 14:09:33 2025 +0800
[GLUTEN-10703] Refactor `PlanNode` to avoid `addAll` call (#10704)
---
.../org/apache/gluten/substrait/plan/PlanBuilder.java | 4 ----
.../java/org/apache/gluten/substrait/plan/PlanNode.java | 17 ++++++-----------
2 files changed, 6 insertions(+), 15 deletions(-)
diff --git
a/gluten-substrait/src/main/java/org/apache/gluten/substrait/plan/PlanBuilder.java
b/gluten-substrait/src/main/java/org/apache/gluten/substrait/plan/PlanBuilder.java
index 114fe3ed82..8c5648b2fa 100644
---
a/gluten-substrait/src/main/java/org/apache/gluten/substrait/plan/PlanBuilder.java
+++
b/gluten-substrait/src/main/java/org/apache/gluten/substrait/plan/PlanBuilder.java
@@ -44,10 +44,6 @@ public class PlanBuilder {
return new PlanNode(mappingNodes, relNodes, outNames, outputSchema,
extension);
}
- public static PlanNode makePlan(AdvancedExtensionNode extension) {
- return new PlanNode(extension);
- }
-
public static PlanNode makePlan(
SubstraitContext subCtx, List<RelNode> relNodes, List<String> outNames) {
return makePlan(subCtx, relNodes, outNames, null, null);
diff --git
a/gluten-substrait/src/main/java/org/apache/gluten/substrait/plan/PlanNode.java
b/gluten-substrait/src/main/java/org/apache/gluten/substrait/plan/PlanNode.java
index 2f0715ac1b..0dd4a74bbc 100644
---
a/gluten-substrait/src/main/java/org/apache/gluten/substrait/plan/PlanNode.java
+++
b/gluten-substrait/src/main/java/org/apache/gluten/substrait/plan/PlanNode.java
@@ -26,13 +26,12 @@ import io.substrait.proto.PlanRel;
import io.substrait.proto.RelRoot;
import java.io.Serializable;
-import java.util.ArrayList;
import java.util.List;
public class PlanNode implements Serializable {
- private final List<FunctionMappingNode> mappingNodes = new ArrayList<>();
- private final List<RelNode> relNodes = new ArrayList<>();
- private final List<String> outNames = new ArrayList<>();
+ private final List<FunctionMappingNode> mappingNodes;
+ private final List<RelNode> relNodes;
+ private final List<String> outNames;
private TypeNode outputSchema = null;
private AdvancedExtensionNode extension = null;
@@ -43,17 +42,13 @@ public class PlanNode implements Serializable {
List<String> outNames,
TypeNode outputSchema,
AdvancedExtensionNode extension) {
- this.mappingNodes.addAll(mappingNodes);
- this.relNodes.addAll(relNodes);
- this.outNames.addAll(outNames);
+ this.mappingNodes = mappingNodes;
+ this.relNodes = relNodes;
+ this.outNames = outNames;
this.outputSchema = outputSchema;
this.extension = extension;
}
- PlanNode(AdvancedExtensionNode extension) {
- this.extension = extension;
- }
-
public Plan toProtobuf() {
Plan.Builder planBuilder = Plan.newBuilder();
// add the extension functions
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
