PHILO-HE commented on code in PR #10669:
URL:
https://github.com/apache/incubator-gluten/pull/10669#discussion_r2343799522
##########
shims/spark35/src/main/scala/org/apache/gluten/sql/shims/spark35/Spark35Shims.scala:
##########
@@ -304,24 +304,32 @@ class Spark35Shims extends SparkShims {
override def getWindowGroupLimitExecShim(plan: SparkPlan):
WindowGroupLimitExecShim = {
val windowGroupLimitPlan = plan.asInstanceOf[WindowGroupLimitExec]
+ val mode = windowGroupLimitPlan.mode match {
+ case Partial => GlutenPartial
+ case Final => GlutenFinal
+ }
Review Comment:
Maybe, we can define Scala implicit conversions in shims/common, then import
them here for implicit conversion between Partial and GlutenPartial at compile
time. This can simplify the code a bit. Please consider whether it is worth
doing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
