zhztheplayer opened a new pull request, #10835:
URL: https://github.com/apache/incubator-gluten/pull/10835

   This is to propose a new API to support the calls like:
   
   ```scala
   val allGlutenCoreEntries = GlutenCoreConfig.allEntries
   val allGlutenEntries = GlutenConfig.allEntries
   val allVeloxEntries = VeloxConfig.allEntries
   ```
   
   The story behind this is, I was trying to add a new `VeloxDeltaConfig` 
object in PR https://github.com/apache/incubator-gluten/pull/10801, but 
`ConfigEntry.getAllEntries` returns uncertain results when switching on / off 
`-P delta` Maven profile, so CI test that does golden checks for the documented 
configuration options fails. So we should add a reliable API that returns 
whatever we need no matter how we trigger the test using Maven.
   
   For example, after the PR change, `VeloxConfig.allEntries` will return 
exactly the config options that are registered in `VeloxConfig` only.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to