JunhyungSong commented on code in PR #10831:
URL:
https://github.com/apache/incubator-gluten/pull/10831#discussion_r2399412355
##########
gluten-substrait/src/main/scala/org/apache/gluten/extension/columnar/PushDownInputFileExpression.scala:
##########
@@ -125,9 +125,9 @@ object PushDownInputFileExpression {
partitionPruningPred = child.partitionPruningPred,
prunedOutput = child.prunedOutput
)(child.session)
- case p @ ProjectExec(projectList, child: BatchScanExecTransformer)
+ case p @ ProjectExec(projectList, child: BatchScanExecTransformerBase)
if projectList.exists(containsInputFileRelatedExpr) =>
- child.copy(output = p.output.asInstanceOf[Seq[AttributeReference]])
+ child.withNewOutput(p.output.asInstanceOf[Seq[AttributeReference]])
Review Comment:
DeltaScanTransformer extends FileSourceScanExecTransformerBase. So,
https://github.com/apache/incubator-gluten/pull/10831/commits/fba3e727ad3b3df5837db5bd16f09ec61e04abbe#diff-d350dba2dc24e5c89b32766f8ab3c2f7eb4e3131b7625080a545d98f44f69ec3R117
needs to be changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
