zhanglistar commented on code in PR #10815:
URL:
https://github.com/apache/incubator-gluten/pull/10815#discussion_r2415463964
##########
cpp-ch/local-engine/Common/QueryContext.cpp:
##########
@@ -200,14 +216,18 @@ void QueryContext::finalizeQuery(int64_t id)
size_t currentThreadGroupMemoryUsage()
{
if (!CurrentThread::getGroup())
- throw DB::Exception(ErrorCodes::LOGICAL_ERROR, "Thread group not
found, please call initializeQuery first.");
+ {
Review Comment:
> Cannot use exception here, the jvm resource may become invalid
I mean we should log this exception, not really throw exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
