WangGuangxin commented on code in PR #9058:
URL: https://github.com/apache/incubator-gluten/pull/9058#discussion_r2390409665
##########
cpp/velox/operators/serializer/VeloxColumnarToRowConverter.cc:
##########
@@ -70,7 +70,7 @@ void
VeloxColumnarToRowConverter::refreshStates(facebook::velox::RowVectorPtr ro
void VeloxColumnarToRowConverter::convert(std::shared_ptr<ColumnarBatch> cb,
int64_t startRow) {
auto veloxBatch = VeloxColumnarBatch::from(veloxPool_.get(), cb);
- refreshStates(veloxBatch->getRowVector(), startRow);
Review Comment:
@zhli1142015 at first, this is one codepath of `ColumnarBatch.select`, and
it's flattend in `ColumnarBatch.select`. Since `ColumnarBatch.select` does not
do flatten, so I move it here.
But I just checked that `UnsafeRowFast` doesn't require input vector is
flatten. So I think it's save to revert change here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
