FelixYBW commented on issue #4392:
URL: 
https://github.com/apache/incubator-gluten/issues/4392#issuecomment-3392632394

   > [@FelixYBW](https://github.com/FelixYBW), we didn't realize this issue 
before. In Gluten's current resource profile rule, when whole stage fallback 
occurs, the offheap memory is reduced to 10% of the original value. Then, if I 
understand correctly, this setting can cause perf regression.
   
   You are right. with whole stage fallback, we may just config onheap memory 
and disable the offheap memory. 10% offheap memory definitely will leads to 
more spill.
   
   We need a list of operators which still need large onheap memory when we 
enable offheap memory.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to