PHILO-HE commented on code in PR #10883: URL: https://github.com/apache/incubator-gluten/pull/10883#discussion_r2431001044
########## dev/release/package-release.sh: ########## @@ -15,7 +15,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -# Note: Manually create $GLUTEN_HOME/release/ and place the release JARs inside. +# Note: The script looks up the release JARs inside $GLUTEN_HOME/package/target/. Review Comment: I have created one GHA job to build Gluten, and then upload the JARs. The job is auto triggered when tag like v1.5.0-rc0 is created in the repo. https://github.com/apache/incubator-gluten/actions/runs/18470382803/job/52622515460 So $GLUTEN_HOME/release/ is used to manually place the JARs. The JARs can be obtained from either the above GHA job (recommended) or manual build. ########## docs/get-started/CreateRelease.md: ########## Review Comment: Can we move this doc to `dev/release/` together with the release scripts? I think this doc is primarily for release managers' reference. So it seems not necessary to expose it to broader readers by putting it here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
