PHILO-HE commented on code in PR #10793: URL: https://github.com/apache/incubator-gluten/pull/10793#discussion_r2377976352
########## docs/developers/NewToGluten.md: ########## @@ -95,32 +64,25 @@ Install the Linux IntelliJ version, and debug code locally. - Download [IntelliJ Linux community version](https://www.jetbrains.com/idea/download/?fromIDE=#section=linux) to Linux server - Start Idea, `bash <idea_dir>/idea.sh` -## Set up Gluten project +#### Set up Gluten project - Make sure you have compiled Gluten. - Load the Gluten by File->Open, select <gluten_home/pom.xml>. - Activate your profiles such as <backends-velox>, and Reload Maven Project, you will find all your need modules have been activated. - Create breakpoint and debug as you wish, maybe you can try `CTRL+N` to find `TestOperator` to start your test. Review Comment: I just replaced "TestOperator" with "a test class" to make it generic. Thanks. ########## docs/developers/NewToGluten.md: ########## @@ -95,32 +64,25 @@ Install the Linux IntelliJ version, and debug code locally. - Download [IntelliJ Linux community version](https://www.jetbrains.com/idea/download/?fromIDE=#section=linux) to Linux server - Start Idea, `bash <idea_dir>/idea.sh` -## Set up Gluten project +#### Set up Gluten project - Make sure you have compiled Gluten. - Load the Gluten by File->Open, select <gluten_home/pom.xml>. - Activate your profiles such as <backends-velox>, and Reload Maven Project, you will find all your need modules have been activated. - Create breakpoint and debug as you wish, maybe you can try `CTRL+N` to find `TestOperator` to start your test. -## Java/Scala code style +#### Java/Scala code style IntelliJ supports importing settings for Java/Scala code style. You can import [intellij-codestyle.xml](../../dev/intellij-codestyle.xml) to your IDE. See [IntelliJ guide](https://www.jetbrains.com/help/idea/configuring-code-style.html#import-code-style). -To generate a fix for Java/Scala code style, you can run one or more of the below commands according to the code modules involved in your PR. +To format Java/Scala code using the Spotless plugin, run the following command: -For Velox backend: -``` -mvn spotless:apply -Pbackends-velox -Pceleborn -Puniffle -Pspark-3.2 -Pspark-ut -DskipTests -mvn spotless:apply -Pbackends-velox -Pceleborn -Puniffle -Pspark-3.3 -Pspark-ut -DskipTests ``` -For Clickhouse backend: -``` -mvn spotless:apply -Pbackends-clickhouse -Pspark-3.2 -Pspark-ut -DskipTests -mvn spotless:apply -Pbackends-clickhouse -Pspark-3.3 -Pspark-ut -DskipTests +./dev/format-scala-code.sh ``` -# CPP code development with Visual Studio Code +### CPP code development Review Comment: Fixed. Using C++ is better. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
